Repository navigation
Fail boot if DAC is in ITS with KMU enabled - #766
Open
ArekBalysNordic wants to merge 1 commit into
Open
ArekBalysNordic wants to merge 1 commit into
ArekBalysNordic wants to merge 1 commit into
Conversation
ArekBalysNordic
force-pushed
the
fix_dac_its
branch
4 times, most recently
from
October 22, 2026 14:25
3664063 to
5b57dc5
Compare
kkasperczyk-no
approved these changes
Oct 23, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unexpected PSA lookup errors bypass the boot guard, and the advertised configuration option is missing.
2 open issues
What changed in this PR
This PR adds a boot-time check to the nRF Connect factory-data provider to reject a device attestation certificate (DAC) private key remaining in PSA ITS when CRACEN KMU storage is configured.
Changes:
- Checks for the ITS key before moving factory-data credentials into secure storage.
- Logs a reprovisioning message and aborts initialization when the key is found.
| File | Description |
|---|---|
| src/platform/nrfconnect/FactoryDataProvider.h | Declares the KMU-specific ITS key check. |
| src/platform/nrfconnect/FactoryDataProvider.cpp | Implements the lookup and invokes the fatal boot guard. |
Review effort: Balanced
ArekBalysNordic
force-pushed
the
fix_dac_its
branch
from
October 23, 2026 06:40
5b57dc5 to
b4d5945
Compare
ArekBalysNordic
force-pushed
the
fix_dac_its
branch
from
October 23, 2026 08:36
b4d5945 to
e576494
Compare
…lected Detect when the DAC private key remains in PSA ITS while factory data is configured to migrate the key to CRACEN KMU. Abort boot in that case unless CHIP_CRYPTO_PSA_DAC_PRIV_KEY_KMU_ITS_FALLBACK is enabled; then sign attestations with the ITS key and log a warning because ITS-to-KMU migration is not supported. Extend KMU-related Kconfig dependencies to CRACEN_LIB_KMU. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
fix_dac_its
branch
from
October 23, 2026 09:10
e576494 to
7801aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CONFIG_CHIP_CRYPTO_PSA_DAC_PRIV_KEY_FATAL_IF_IN_ITS to detect
a DAC private key still stored in PSA ITS when factory data is
configured for CRACEN KMU.
Testing
ncs-matter